fix: AnnotationUtils cache misses due to reinstantiation of ModelConverterContext#5114
Open
ldt-fweichert wants to merge 5 commits intoswagger-api:masterfrom
Open
fix: AnnotationUtils cache misses due to reinstantiation of ModelConverterContext#5114ldt-fweichert wants to merge 5 commits intoswagger-api:masterfrom
ldt-fweichert wants to merge 5 commits intoswagger-api:masterfrom
Conversation
5847db2 to
0f4e682
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ModelConverterContextImplstores each already processed type and it's correspondingSchemainternally. When types are discovered multiple times during resolution, they should be converted only once. Multiple usages of static helper functions onAnnotationUtilsinstantiated a newModelConverterContextinstead of reusing the initial one effectivley ignoring the cache of processed types.This PR adds a
ModelConverterContext context-Parameter to someAnnotationUtilshelpers to reuse the instance during resolution. This speeds up resolution, especially with Recursive Models, where resolving Models with 10 subtypes could require at least multiple hours of processing time.Two questions from my side remain:
ModelConverterContextbe instantiated insideAnnotationUtilsat all? If no, the overloads created in this PR should be removed entirely, to ensure correct usage. An additional null-check should be added as well.Fixes: #5091
Type of Change
Checklist