Skip to content

Update docker workflows#673

Merged
Bisaloo merged 3 commits into
mainfrom
frog-update-workflows-1
Nov 10, 2025
Merged

Update docker workflows#673
Bisaloo merged 3 commits into
mainfrom
frog-update-workflows-1

Conversation

@froggleston

Copy link
Copy Markdown
Contributor

This PR updates the sandpaper GHA workflows to new versions which:

  • are smaller and cleaner, using new carpentries/actions instead
  • have improved triggers and checks

@froggleston froggleston requested a review from Bisaloo September 30, 2025 15:43
@github-actions

Copy link
Copy Markdown

ℹ️ Modified Workflows

This pull request contains modified workflow files and no preview will be created.

Workflow files modified:

  • .github/workflows/docker_apply_cache.yaml
  • .github/workflows/docker_build_deploy.yaml
  • .github/workflows/docker_pr_receive.yaml
  • .github/workflows/pr-comment.yaml
  • .github/workflows/sandpaper-version.txt
  • .github/workflows/update-cache.yaml

If this is not from a trusted source, please inspect the changes for any malicious content.

Comment thread .github/workflows/update-cache.yaml Outdated
steps.validate-org-workflow.outputs.is_valid == 'false'
)
uses: carpentries/create-pull-request@main
uses: peter-evans/create-pull-request@v7

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this pin a specific commit hash? My understanding is that it was forked in the carpentries to ensure no malicious updates could be pushed to this action used across all Carpentries organizations.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could! I would definitely prefer that than managing our own fork of third party actions.

Comment thread .github/workflows/update-cache.yaml Outdated
Comment thread .github/workflows/docker_pr_receive.yaml Outdated
@froggleston

froggleston commented Nov 10, 2025

Copy link
Copy Markdown
Contributor Author

@Bisaloo I've updated these workflows to fix a range of recent issues, but they currently require a test branch of the carpentries/actions. As a result if everything now works as it should, then we'll need to do another update to use the main actions once my changes have been tested and merged in.

@Bisaloo Bisaloo merged commit 98754a3 into main Nov 10, 2025
6 checks passed
@Bisaloo Bisaloo deleted the frog-update-workflows-1 branch November 10, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants