Read the bot App id from the ruled variable, not the deleted secret - #33
Merged
Conversation
The org secrets SWIFT_INSTITUTE_BOT_APP_CLIENT_ID and
SWIFT_INSTITUTE_BOT_APP_ID were deleted under ruling #395. This caller
still forwarded both to configure-private-repos, so the composite's
`client-id: ${{ app-client-id || app-id }}` resolved to empty and
create-github-app-token failed hard.
Adopt the #414 house pattern: one input, from the org variable. The
action's client-id accepts an App id as well as a Client id per
create-github-app-token v2+, so the deprecated app-id input is dead
weight and is removed rather than repointed. The private key stays a
secret.
![swift-institute-bot[bot]](https://avatars.githubusercontent.com/in/3543256?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a consumption of the org secrets deleted under ruling #395.
configure-private-reposforwardsclient-id: ${{ app-client-id || app-id }}toactions/create-github-app-token. This caller passed both inputs from the deleted secrets, so that expression resolves to empty and the action fails hard.Adopts the #414 house pattern: one input, from the org variable
vars.SWIFT_INSTITUTE_BOT_APP_ID(present atswift-foundationsorg scope, visibilityall). Per thecreate-github-app-tokenv2+ contract — quoted in the composite action's own header —client-idaccepts an App id as well as a Client id, so the deprecatedapp-idinput is dead weight and is removed rather than repointed. The private key stays a secret and is untouched.Site:
.github/workflows/windows-6.4-proof.yml(1 site).Part of the #395/#414 mint breakage census. Authored by peer task
mint-breakage-census; do not merge without the coordinator.