Remove URL workaround for Linux crash once SCL-F is rebuilt#1252
Merged
Conversation
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
Works locally on my Ubuntu 22.04 aarch64 image, but fails in CI's Ubuntu 22.04 x86 image |
Contributor
Author
|
@swift-ci please test Linux Platform |
Contributor
Author
|
Tested on an x86 Ubuntu 22.04 image locally with |
Contributor
Author
|
@swift-ci please test Linux Platform |
Contributor
Author
|
|
jmschonfeld
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with a recent nightly-main container, and removing the Linux-only workaround
unsafeBitCast == 0x1check works now that swift-corelibs-foundation was built with the new swift-foundationURLchanges in #1238.Removing the other
private var _paddingworkaround still causes a crash in libXCTest on Linux, so that will require further investigation.