fix: add missing pinned-columns mixin to body-row component#2269
Open
hugodemelo wants to merge 1 commit intoswimlane:masterfrom
Open
fix: add missing pinned-columns mixin to body-row component#2269hugodemelo wants to merge 1 commit intoswimlane:masterfrom
hugodemelo wants to merge 1 commit intoswimlane:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
Column pinning (left/right frozen columns) is broken for body rows in v22. The pinned columns in the header stick correctly, but the body row columns scroll away with the rest of the content.
This can be reproduced on the official demo page: https://swimlane.github.io/ngx-datatable/#/pinning
What is the new behavior?
Body row pinned columns now stay sticky when scrolling horizontally, matching the header behavior.
The fix includes the existing pinned-columns() SCSS mixin in body-row.component.scss, mirroring what header.component.scss already does.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
In v22, the migration to standalone components with Angular's default view encapsulation (scoped styles) meant each component needs its own pinned-columns() mixin include.
It was present in header.component.scss but missing from body-row.component.scss.