Skip to content

[version-control] Switch default version control diff tool to git-gutter - #15058

Closed
sunlin7 wants to merge 1 commit into
syl20bnr:developfrom
sunlin7:switch-to-git-gutter
Closed

[version-control] Switch default version control diff tool to git-gutter#15058
sunlin7 wants to merge 1 commit into
syl20bnr:developfrom
sunlin7:switch-to-git-gutter

Conversation

@sunlin7

@sunlin7 sunlin7 commented Sep 23, 2021

Copy link
Copy Markdown
Contributor

The default version control diff tool https://github.com/nonsequitur/git-gutter-plus and https://github.com/nonsequitur/git-gutter-fringe-plus are out of maintained for 6+ years, and has bugs for tramp (eg: nonsequitur/git-gutter-plus#43 ).

Switch default VC diff tool to https://github.com/emacsorphanage/git-gutter for which is well maintained.

Switch default version control diff tool to git-gutter for original default
git-gutter+ has bugs and no maintain for years.
@sunlin7

sunlin7 commented Sep 24, 2021

Copy link
Copy Markdown
Contributor Author

@lebensterben The document files are updated, please review again. Thanks.

@lebensterben

Copy link
Copy Markdown
Contributor

I'm not familiar with the reason why git-gutter+ was selected as the default implementation.
So let's wait for approval(s) from more reviewers.

@smile13241324

Copy link
Copy Markdown
Collaborator

I have double checked the packages and @sunlin7 is right the current default is not maintained anymore. A quick test revealed no obvious loses in functionality in comparison with the non "+" implementations. With regards to future security fixes and adjustments to modern emacs versions I think it would be preferable to use the maintained packages by default.

Therefore I have merged the PR.

@sunlin7

sunlin7 commented Sep 29, 2021

Copy link
Copy Markdown
Contributor Author

@smile13241324 Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants