Add mago formatter recipe - #1811
Conversation
|
Thanks for the PR 😍 How to test these changes in your application
Diff between recipe versionsIn order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. |
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
|
The pipeline is failling because it doesn't support installing composer plugins 🤔 In theory mago could in fact setup it's own config by itself upon installation but I still think using flex here could help to maintain a config with sensible defaults and continue providing upgrades as the configuration's schema changes. |
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
@azjezz Hi, could you please review if this recipe aligns with https://github.com/carthage-software/mago generic configuration for symfony project.
Personally, I would like for format section to be removed, symfony plugin enabled, bin path removed and php_version somehow resolved at runtime and specified dynamically.
|
The format section is exactly the default generated by the command |
Head branch was pushed to by a user without write access
|
@Zuruuh What's the status of this PR? |
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
`post-install.txt`
Head branch was pushed to by a user without write access
|
@fabpot I've just updated the pr to work with mago v1.0 👍 The CI is still failling because the composer package is a plugin and should be explicitely disabled in CI. Would it be fine if I do a followup pr to do it in the main |
Uh oh!
There was an error while loading. Please reload this page.