Skip to content

Add mago formatter recipe - #1811

Merged
symfony-recipes-bot merged 7 commits into
symfony:mainfrom
Zuruuh:mago
Sep 24, 2025
Merged

Add mago formatter recipe#1811
symfony-recipes-bot merged 7 commits into
symfony:mainfrom
Zuruuh:mago

Conversation

@Zuruuh

@Zuruuh Zuruuh commented May 30, 2025

Copy link
Copy Markdown
Contributor

@symfony-recipes-bot
symfony-recipes-bot enabled auto-merge (squash) May 30, 2025 19:08
@github-actions

github-actions Bot commented May 30, 2025

Copy link
Copy Markdown

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1811/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1811/index.json
  2. Install the package(s) related to this recipe:

    composer req symfony/flex
    composer req 'carthage-software/mago:^1.0'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

auto-merge was automatically disabled May 30, 2025 19:23

Head branch was pushed to by a user without write access

@symfony-recipes-bot
symfony-recipes-bot enabled auto-merge (squash) May 30, 2025 19:23
auto-merge was automatically disabled May 30, 2025 19:43

Head branch was pushed to by a user without write access

@symfony-recipes-bot
symfony-recipes-bot enabled auto-merge (squash) May 30, 2025 19:43
auto-merge was automatically disabled May 30, 2025 19:54

Head branch was pushed to by a user without write access

@symfony-recipes-bot
symfony-recipes-bot enabled auto-merge (squash) May 30, 2025 19:54
@Zuruuh

Zuruuh commented May 30, 2025

Copy link
Copy Markdown
Contributor Author

The pipeline is failling because it doesn't support installing composer plugins 🤔 In theory mago could in fact setup it's own config by itself upon installation but I still think using flex here could help to maintain a config with sensible defaults and continue providing upgrades as the configuration's schema changes.

auto-merge was automatically disabled May 30, 2025 20:07

Head branch was pushed to by a user without write access

@symfony-recipes-bot
symfony-recipes-bot enabled auto-merge (squash) May 30, 2025 20:08

@diimpp diimpp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azjezz Hi, could you please review if this recipe aligns with https://github.com/carthage-software/mago generic configuration for symfony project.

Personally, I would like for format section to be removed, symfony plugin enabled, bin path removed and php_version somehow resolved at runtime and specified dynamically.

@Zuruuh

Zuruuh commented Jun 2, 2025

Copy link
Copy Markdown
Contributor Author

The format section is exactly the default generated by the command mago init. For the linter section I commented it because it would raise warnings on a default symfony skeleton app 👍 (But yeah we could enable it)

Comment thread carthage-software/mago/0.24/mago.toml Outdated
Comment thread carthage-software/mago/0.24/mago.toml Outdated
auto-merge was automatically disabled June 4, 2025 23:11

Head branch was pushed to by a user without write access

@symfony-recipes-bot
symfony-recipes-bot enabled auto-merge (squash) June 4, 2025 23:11
@fabpot

fabpot commented Sep 22, 2025

Copy link
Copy Markdown
Member

@Zuruuh What's the status of this PR?

auto-merge was automatically disabled September 22, 2025 07:24

Head branch was pushed to by a user without write access

@symfony-recipes-bot
symfony-recipes-bot enabled auto-merge (squash) September 22, 2025 07:25
auto-merge was automatically disabled September 22, 2025 07:31

Head branch was pushed to by a user without write access

@symfony-recipes-bot
symfony-recipes-bot enabled auto-merge (squash) September 22, 2025 07:31
auto-merge was automatically disabled September 22, 2025 07:38

Head branch was pushed to by a user without write access

@symfony-recipes-bot
symfony-recipes-bot enabled auto-merge (squash) September 22, 2025 07:38
auto-merge was automatically disabled September 22, 2025 07:46

Head branch was pushed to by a user without write access

@symfony-recipes-bot
symfony-recipes-bot enabled auto-merge (squash) September 22, 2025 07:47
@Zuruuh

Zuruuh commented Sep 22, 2025

Copy link
Copy Markdown
Contributor Author

@fabpot I've just updated the pr to work with mago v1.0 👍 The CI is still failling because the composer package is a plugin and should be explicitely disabled in CI. Would it be fine if I do a followup pr to do it in the main symfony/recipes's github action ? (Since they share the same CI)

@symfony-recipes-bot
symfony-recipes-bot merged commit 8b46758 into symfony:main Sep 24, 2025
1 of 2 checks passed
@Zuruuh
Zuruuh deleted the mago branch September 25, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants