-
-
Notifications
You must be signed in to change notification settings - Fork 719
Add recipe for codevenom/fakturownia-bundle 0.1 (#1974) #1974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
symfony-recipes-bot
merged 7 commits into
symfony:main
from
levan-cdv:codevenom-fakturownia-bundle
May 5, 2026
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5b82d1d
Add recipe for codevenom/fakturownia-bundle 0.1 (#1974)
levan-cdv f0eeea8
Fix YAML indentation in codevenom/fakturownia-bundle 0.1 configuratio…
levan-cdv 46af0fb
Fix trailing newlines in codevenom/fakturownia-bundle 0.1 configurati…
levan-cdv ff22bcf
Re-run recipe QA
levan-cdv ed112ff
Re-run recipe QA with latest bundle changes
levan-cdv aeb3ded
Re-run recipe QA
levan-cdv b128ebd
Dropped support for symfony 6 due to mcp issues
levan-cdv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
8 changes: 8 additions & 0 deletions
8
codevenom/fakturownia-bundle/0.1/config/packages/codevenom_fakturownia.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| codevenom_fakturownia: | ||
| base_url: '%env(FAKTUROWNIA_BASE_URL)%' | ||
| api_token: '%env(FAKTUROWNIA_API_TOKEN)%' | ||
| seller_name: '%env(default::FAKTUROWNIA_SELLER_NAME)%' | ||
| seller_tax_id: '%env(default::FAKTUROWNIA_SELLER_TAX_ID)%' | ||
| downloads_path: '%kernel.project_dir%/var/fakturownia' | ||
| timeout: 10 | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| mcp: | ||
| app: 'codevenom-fakturownia' | ||
| version: '1.0.0' | ||
| instructions: 'MCP server exposing Fakturownia tools.' | ||
| client_transports: | ||
| http: true | ||
| http: | ||
| path: '/_mcp' | ||
| session: | ||
| store: 'file' | ||
| directory: '%kernel.cache_dir%/mcp-sessions' | ||
| ttl: 3600 | ||
| discovery: | ||
| scan_dirs: | ||
| - '%kernel.project_dir%/src' | ||
| - '%kernel.project_dir%/vendor/codevenom/fakturownia-bundle' | ||
|
|
4 changes: 4 additions & 0 deletions
4
codevenom/fakturownia-bundle/0.1/config/routes/codevenom_fakturownia_mcp.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| mcp: | ||
| resource: . | ||
| type: mcp | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "bundles": { | ||
| "Codevenom\\FakturowniaBundle\\CodevenomFakturowniaBundle": ["all"] | ||
| }, | ||
| "copy-from-recipe": { | ||
| "config/": "%CONFIG_DIR%/" | ||
| }, | ||
| "env": { | ||
| "FAKTUROWNIA_BASE_URL": "https://app.fakturownia.pl", | ||
| "FAKTUROWNIA_API_TOKEN": "", | ||
| "FAKTUROWNIA_SELLER_NAME": "", | ||
| "FAKTUROWNIA_SELLER_TAX_ID": "" | ||
| } | ||
| } | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to skip the QA check that installs the recipe into a
symfony/skeleton:^6project?This bundle currently does not support Symfony 6 because it depends on
symfony/mcp-bundle, which is not compatible with Symfony 6. The bundle is intended to support Symfony 7+ only.I can keep the bundle constraints explicit in
composer.json, for example requiring Symfony^7.0 || ^8.0, but the current QA matrix still tries to install it into a Symfony 6 skeleton and fails during Composer dependency resolution.Here is the
composer.json- https://github.com/codevenom-co/fakturownia-bundle/blob/023d75cc20bebab768d0fec5e0c86a33aacc53e3/composer.json#L8Is there a recommended way for Symfony 7+ only bundles/recipes to handle this in
recipes-contrib?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
QA checks don't need to fully pass in order for PR to be merged. If package doesn't support SF6 -- that's totally fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks