INTIJC-7 - Refactor of JenkinsProxyHelper to provide instance methods#7
Closed
DanaMaxfield wants to merge 3 commits into
Closed
INTIJC-7 - Refactor of JenkinsProxyHelper to provide instance methods#7DanaMaxfield wants to merge 3 commits into
DanaMaxfield wants to merge 3 commits into
Conversation
| private String ntlmWorkstation; | ||
| private ProxyInfo proxyInfo = ProxyInfo.NO_PROXY_INFO; | ||
|
|
||
| public JenkinsProxyHelper(final ProxyConfiguration proxyConfiguration, final String url) { |
There was a problem hiding this comment.
I think this constructor should be changed to a static method to construct a JenkinsProxyHelper. From the fields listed, the second constructor seems more appropriate and this seems more like it should be a static helper method to construct a JenkinsProxyHelper using the ProxyConfiguration.
rottebds
suggested changes
May 18, 2020
added 2 commits
May 20, 2020 07:23
… (INTIJC-7) - Change constructor to take Jenkins vs ProxyConfiguration - Parse Jenkins in private method vs constructor - Pass url to getProxyInfo() to allow using same object for multiple url's - Removal of static methods marked Deprecated - Removal of unneeded 'final' (IDE setting)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor of JenkinsProxyHelper to provide instance methods and deprecate, or possibly remove, static methods.
The user will now be required to provide a valid ProxyConfiguration object as a parameter OR all of the values that would be part of a ProxyConfiguration object. Regardless of which constructor is called, both will leverage getProxyInfo() to return an instance of ProxyInfo.
NOTE: All tests within #4 were run successfully in my local environment. These tests are only for the static methods. If the statics methods are moved vs deprecated, that PR will be closed and the branch removed.