night-shift: personal-llm one-click run parity (item 43) - #7
Merged
Conversation
Adds run.cmd matching jarvis-launcher's jarvis.config.json "chat UI" action verbatim (venv streamlit + open http://localhost:8501, no env var since the config sets none), plus offline tests asserting the exact command string, the absence of an invented env var, and the nested-quoting bug class guard used by the CivilizationOS/resume-job-fit-ai/recall/ghostwriter/github-pr-agent precedents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
run.cmdat the repo root that starts the Streamlit chat UI via the venvand opens
http://localhost:8501in the default browser, mirroringjarvis-launcher's
jarvis.config.json"Personal LLM - Chat" project's default"chat UI" action verbatim:
opening
http://localhost:8501. That action sets noenvkey, sorun.cmddoes not invent one (no
PYTHONIOENCODING, unlike some sibling repos' actions).Also adds
tests/test_run_cmd.py: offline, static-content-only tests thatassert the file exists, the command string matches the config verbatim, no
env var was invented, the script never touches the gateway auth token or
data/, and it avoids the nested-quoting bug class jarvis-launcher's launcherrewrite fixed.
Why
PROJECT-GENESIS.md Tier 6 item 43: "one-click run parity - every repo gets a
run.cmd(or npm script) that starts backend + frontend + opens the browser,matching its jarvis.config.json action, so the launcher and the repo never
drift." CivilizationOS, resume-job-fit-ai, recall, ghostwriter, and
github-pr-agent already have this from prior nights; personal-llm was next on
the remaining list.
How verified
(torch via sentence-transformers, chromadb, etc.) was impractical to fully
install in this sandbox (multi-hundred-MB downloads timed out), so:
(
pydantic,pydantic-settings,fastapi,typer,httpx,python-dotenv,networkx,python-multipart,pytest).origin/masterwith these installed:99 passed, 10 failed, 34 errors- all 10 failures and 34 errors are pre-existingModuleNotFoundErrors for deps not installed (pyttsx3,pytesseract,chromadb-backed fixtures,google-genai,ollama, etc.), confirmed byrunning the identical command against master before this change.
run.cmd+tests/test_run_cmd.py:105 passed, 10 failed, 34 errors- the 6 new tests all pass, and the failed/errored counts arebyte-for-byte identical to the baseline (same test names), so this change
introduces zero regressions and zero new failures.
would require network access this sandbox could not sustain for the
torch/CUDA wheel downloads.