Add SQL Lab query limits and timeout caps - #118
Merged
Conversation
Set SQL_MAX_ROW=10000, DEFAULT_SQLLAB_LIMIT=1000, SQLLAB_TIMEOUT=300s, and SQLLAB_VALIDATION_TIMEOUT=60s to prevent unbounded queries from exhausting memory or blocking worker threads. Closes #81 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
szachovy
pushed a commit
that referenced
this pull request
Apr 10, 2026
PR #118 explicitly set SQL_QUERY_MUTATOR = None. Superset 4.0 calls this as a function during SQL Lab async query execution via Celery, so setting it to None causes 'NoneType' object is not callable and the query state returns 'failed'. It defaults to None internally when unset, so the line is both redundant and breaking.
szachovy
pushed a commit
that referenced
this pull request
Apr 10, 2026
PR #118 set SQL_QUERY_MUTATOR = None which caused 'NoneType' object is not callable in the Celery sql_lab worker. The previous commit removed that line, but explicitly defining the passthrough function ensures the Superset config module loading path cannot re-introduce a None value regardless of import order or config overlay behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set
SQL_MAX_ROW=10000,DEFAULT_SQLLAB_LIMIT=1000,SQLLAB_TIMEOUT=300s, andSQLLAB_VALIDATION_TIMEOUT=60s to prevent unbounded queries from exhausting memory or blocking worker threads.Closes #81