Strengthen MySQL superset password generation - #121
Merged
Conversation
Replace random.choice with secrets.choice for CSPRNG, expand charset from lowercase-only to ascii_letters+digits+punctuation, and increase length from 12 to 24 characters. The previous password had ~56 bits of entropy; the new one has ~157 bits. Closes #89 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
szachovy
pushed a commit
that referenced
this pull request
Apr 10, 2026
PR #121 strengthened the password but used string.punctuation which includes > + [ ] @ : / and other chars that are invalid or require percent-encoding in a MySQL URI (used in mysql-mgmt --bootstrap and SQLAlchemy connection strings). Restrict to alphanumeric only: 24 chars of [A-Za-z0-9] gives ~143 bits of entropy which is sufficient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace random.choice with secrets.choice (CSPRNG), expand charset from lowercase-only to ascii_letters+digits+punctuation, and increase length from 12 to 24 characters (~56 to ~157 bits entropy).
Closes #89