@W-22169638: Rename ToolName -> WebToolName#323
@W-22169638: Rename ToolName -> WebToolName#323anyoung-tableau wants to merge 7 commits intoanyoung/abstract-serverfrom
Conversation
|
|
||
| // The name of the tool | ||
| name: ToolName; | ||
| name: WebToolName; |
There was a problem hiding this comment.
Down for the rename where the concept is truly web-specific, but I think this may be pulling shared runtime types in that direction too
Tool and related types here now depend on WebMcpServer / WebToolName, and the same pattern shows up in TableauToolContext and notification.ts
Could make the eventual desktop split more expensive by forcing shared contracts through web-shaped types
Should these stay variant-agnostic here? (with the web-specific narrowing pushed to the registration boundary instead?)
There was a problem hiding this comment.
Yeah, it becomes variant-agnostic in the next PR with a generic type. https://github.com/tableau/tableau-mcp/pull/324/changes#diff-f3873c6faa0be1fa52b6c10d6f3c4188b9abc3848cc6d554578b04181dd8d4f5
2 participants
These changes rename the
ToolNametype (and its associated helpers) toWebToolName. The motivation here is to support the later introduction ofDesktopToolName. See #328