@W-22169856: Rename Tool -> WebTool#324
Open
anyoung-tableau wants to merge 5 commits intoanyoung/web-tool-namefrom
Open
@W-22169856: Rename Tool -> WebTool#324anyoung-tableau wants to merge 5 commits intoanyoung/web-tool-namefrom
anyoung-tableau wants to merge 5 commits intoanyoung/web-tool-namefrom
Conversation
| @@ -0,0 +1,3 @@ | |||
| import { WebToolName } from './toolName.web.js'; | |||
|
|
|||
| export type ToolName = WebToolName; | |||
Contributor
There was a problem hiding this comment.
Could make the shared Tool contract more web-shaped than intended
Tool is generic over TToolName extends ToolName, but ToolName is currently just an alias for WebToolName, so future variants still have to come through a web-defined shared type
This closing question may feel tedious at this point, but regardless: should ToolName stay variant-agnostic here, with web-specific narrowing pushed to the variant boundary instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.