@W-22184369: Move “web” tools to tools/web#326
@W-22184369: Move “web” tools to tools/web#326anyoung-tableau wants to merge 2 commits intoanyoung/web-tool-contextfrom
Conversation
|
|
||
| import { getConfig } from '../../config.js'; | ||
| import type { WebToolName } from '../../tools/toolName.web.js'; | ||
| import type { WebToolName } from '../../tools/web/toolName.js'; |
There was a problem hiding this comment.
Boundary question-cito here: after moving tools under tools/web, shared infrastructure is now importing WebToolName back out of that folder
Import direction is going the wrong way, especially for things like OAuth scope mapping that seem web-specific by nature
Should this web-shaped policy live under tools/web, with only the variant-agnostic scope primitives staying here?
There was a problem hiding this comment.
OAuth scope mapping is definitely web-specific and we won't have any variant-agnostic scopes any time soon. I don't think it belongs under src/tools/web but could live under src/web/server/oauth (meaning we could move server under a new web folder). I don't really feel strongly that it needs to move, at least not now.
2 participants
These changes move all the tools into the
webfolder. The motivation is to support the creation of tools for later variants likeDesktop.