@W-22188550: Add "desktop" build variant#330
@W-22188550: Add "desktop" build variant#330anyoung-tableau wants to merge 1 commit intoanyoung/desktop-tool-contextfrom
Conversation
anyoung-tableau
changed the title
| 'tableau-desktop-mcp-server': './build/index-desktop.js', | ||
| }, | ||
| exports: { | ||
| '.': './build/index-desktop.js', |
There was a problem hiding this comment.
The package wiring is pointing at the wrong file name here, yeah?
The desktop build output is ./build/index.desktop.js, but these package entries use ./build/index-desktop.js, so the published package would resolve to a file the build never produces
Should this be derived from the same source of truth as the build script so they can’t drift?
There was a problem hiding this comment.
Oh good catch. Not sure where that dash came from.
| import { TableauAuthInfo } from './server/oauth/schemas.js'; | ||
|
|
||
| export const serverName = 'tableau-mcp'; | ||
| export const serverName = |
There was a problem hiding this comment.
Boundary Q here: do we want server.ts branching on BUILD_VARIANT at all?
The rest of this stack is trying to keep variant-specific behavior in the entry/variant layer, and putting the conditional in shared code feels like an escape hatch that could spread over time
Should the variant-specific server name come from the entry point or concrete server instead?
2 participants
These changes introduce a
desktopvariant which adds a new build entry point and output artifact that only includes the Desktop tools.