Clear text without delay & update dependencies#132
Open
KilianB wants to merge 8 commits intotameemsafi:mainfrom
Open
Clear text without delay & update dependencies#132KilianB wants to merge 8 commits intotameemsafi:mainfrom
KilianB wants to merge 8 commits intotameemsafi:mainfrom
Conversation
|
I also need this feature. Hopefully this PR will be merged soon. |
|
Also would love to have that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes:
clearmethod which removes characters in batch in a single event loop, thus no delay is noticeable. The current delete all version splits up deletion in single events which result in a delay because the loop is tick based.speedindeleteAllinstead of if it is truthy. This will allow the user to specify a potential delay of 0Minor changes:
React and react dom have been pinned to the current version instead of the .x release. This can and should probably be changed.