Adds border config property#16
Open
gonstoll wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the new
vim.opt.winborderoption, all float borders are affected. For me, I have it set up with"single", which made the Duck float a bit ugly 🫤I imagine this is the same for someone else out there. So I'm just proposing adding a
borderconfig option so you can reset it.I'm not sure this needs to be exposed to the consumers via config, or just straight up set it in
nvim_open_winthough. But I see it as less of a breaking change to default it tonone, and let users handle it however they want.Open to opinions 🤗
Btw, I absolutely love this plugin 😄 I use it every time I pair program or share my screen 😂