fix: map-get deprecated in scss#595
Open
hivenet-tomcrammond wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I noticed that the scss generation using sass 1.85.0 seems to be failing. According to the Heads Up in this document the
map-get()function has become deprecated in due to the switch to the new import system. Unfortunately was not able to determine when this came into effect 🤷♂️Making the changes in this PR resolved the issue for me. Thought it would be helpful for others as well :)
For any troubled developers reading this, know that you can take advantage of these changes without forking the library with the handy-dandy
templatesoption! Just copy thescss.hbsfile to your repo, add this PRs' changes to it and point to it using the templates option in the fantasticon config. Like so: