Skip to content

chore(utils): add type hints to utils functions [python] #4123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yogeshwaran-c wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore(utils): add type hints to utils functions [python] #4123

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0f2978
feat(python): add type hints to utils functions
yogeshwaran-c Apr 28, 2026
7f7a16d
fix(python): refine utils type hints per review (Optional handling, f…
yogeshwaran-c Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions python/bullmq/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,18 @@
import asyncio
import json
import traceback
from typing import Any
from typing import Any, Callable

import semver


def isRedisVersionLowerThan(current_version, minimum_version):
def isRedisVersionLowerThan(current_version: str | None, minimum_version: str) -> bool:
if current_version is None:
return False
return semver.Version.parse(current_version).compare(minimum_version) == -1
Comment on lines +9 to 12


def extract_result(job_task, emit_callback):
def extract_result(job_task: asyncio.Future[Any], emit_callback: Callable[[str, Any], None]) -> Any:
try:
return job_task.result()
except Exception as e:
Expand All @@ -19,9 +22,10 @@ def extract_result(job_task, emit_callback):
traceback.print_exc()
emit_callback("error", e)

def get_parent_key(opts: dict[str, str]):
def get_parent_key(opts: dict[str, str] | None) -> str | None:
if opts:
return f"{opts.get('queue')}:{opts.get('id')}"
return None

def parse_json_string_values(input_dict: dict[str, str]) -> dict[str, dict]:
return {key: json.loads(value) for key, value in input_dict.items()}
Expand Down