Skip to content

Set the baseurl in the constructor, and make it filterable#185

Open
boblinthorst wants to merge 1 commit intotaxjar:masterfrom
boblinthorst:make_baseurl_filterable
Open

Set the baseurl in the constructor, and make it filterable#185
boblinthorst wants to merge 1 commit intotaxjar:masterfrom
boblinthorst:make_baseurl_filterable

Conversation

@boblinthorst
Copy link
Copy Markdown

Describe the problem (reference the issue if applicable) and what the PR accomplishes.

#184

In this PR, I make the baseUrl filterable, so that the baseurl can be changed to https://api.sandbox.taxjar.com.

Steps to Reproduce

  1. Do this
  2. And that
  3. Finally this

Expected Result

After applying the PR, this should happen.

Click-Test Versions

  • Woo 4.0
  • Woo 3.9
  • Woo 3.8
  • Woo 3.7
  • Woo 3.6
  • Woo 3.5
  • Woo 3.4
  • Woo 3.3
  • Woo 3.2
  • Woo 3.1
  • Woo 3.0

Specs Passing

  • Woo 4.0
  • Woo 3.9
  • Woo 3.8
  • Woo 3.7
  • Woo 3.6
  • Woo 3.5
  • Woo 3.4
  • Woo 3.3
  • Woo 3.2
  • Woo 3.1
  • Woo 3.0

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants