Skip to content

Php 8.x compliance#268

Open
meyerauslander wants to merge 3 commits intotaxjar:masterfrom
meyerauslander:php-8.x-compliance
Open

Php 8.x compliance#268
meyerauslander wants to merge 3 commits intotaxjar:masterfrom
meyerauslander:php-8.x-compliance

Conversation

@meyerauslander
Copy link
Copy Markdown

@meyerauslander meyerauslander commented Mar 10, 2025

PHP has deprecated dynamic class props
Warning messages show up in the php error log. e.g.

 PHP Deprecated:  Creation of dynamic property WC_Taxjar_Integration::$method_description is deprecated in /var/www/html/wp-content/plugins/taxjar-simplified-taxes-for-woocommerce/includes/class-wc-taxjar-integration.php on line 39

This PR will prevent these warning messages.

Steps to Reproduce

  • Access any site page.

Expected Result

Clean php error log.

Applies to any instance running PHP 8.2 and up

Solves the problem for all installations

@cla-assistant
Copy link
Copy Markdown

cla-assistant bot commented Mar 10, 2025

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link
Copy Markdown

cla-assistant bot commented Mar 10, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant