Skip to content

🛡️ Sentinel: [HIGH] Add input and history limits to prevent DoS#23

Draft
google-labs-jules[bot] wants to merge 1 commit intomainfrom
sentinel/dos-prevention-limits-3062815038576282386
Draft

🛡️ Sentinel: [HIGH] Add input and history limits to prevent DoS#23
google-labs-jules[bot] wants to merge 1 commit intomainfrom
sentinel/dos-prevention-limits-3062815038576282386

Conversation

@google-labs-jules
Copy link
Copy Markdown
Contributor

🛡️ Sentinel: [HIGH] Add input and history limits to prevent DoS

Vulnerability:
The application was susceptible to Denial of Service (DoS) and memory exhaustion risks due to:

  1. Unlimited input lengths in WelcomeScreen (allowing massive payloads).
  2. Unbounded growth of the transcription array in CallScreen during long sessions.

Fix:

  • Defined MAX_INPUT_LENGTHS (Name: 50, Instructions: 2000, Greeting: 500) and MAX_TRANSCRIPTION_HISTORY (100 entries) in constants.ts.
  • Enforced maxLength on WelcomeScreen input fields.
  • Implemented slicing of transcription history in CallScreen to keep only the most recent 100 entries.
  • Added unit tests to verify these limits.

Verification:

  • pnpm test passed successfully.
  • Verified code changes ensure inputs are truncated and history size is capped.

PR created automatically by Jules for task 3062815038576282386 started by @tblakex01

Added `MAX_INPUT_LENGTHS` to enforce character limits on user inputs (Name, System Instructions, Greeting) in `WelcomeScreen`.
Added `MAX_TRANSCRIPTION_HISTORY` to cap the transcription array size in `CallScreen`, preventing memory exhaustion during long calls.
Updated `constants.ts` with these limits and added verification tests.
@google-labs-jules
Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Dec 28, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants