Skip to content

Spec: Fix bounds check on names field decoding #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkup merged 2 commits into from
Jun 26, 2025
Merged

Spec: Fix bounds check on names field decoding #214

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58ef1d8
Fix bounds check on names field decoding
takikawa Jun 25, 2025
b49ce2e
Merge branch 'main' into fix-names-check
nicolo-ribaudo Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spec.emu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -977,7 +977,7 @@
1. Let _name_ be *null*.
1. If |Name| is present, then
1. Perform DecodeMappingsField of |Name| with arguments _state_, _mappings_, _names_ and _sources_.
1. If _state_.[[NameIndex]] < 0 or _state_.[[NameIndex]] ≥ the number of elements of _sources_, optionally report an error.
1. If _state_.[[NameIndex]] < 0 or _state_.[[NameIndex]] ≥ the number of elements of _names_, optionally report an error.
1. Else, set _name_ to _names_[_state_.[[NameIndex]]].
1. Let _decodedMapping_ be a new DecodedMappingRecord { [[GeneratedPosition]]: _generatedPosition_, [[OriginalPosition]]: _originalPosition_, [[Name]]: _name_ }.
1. Append _decodedMapping_ to _mappings_.
Expand Down