Use fractionDigits & significantDigits options in .convertTo(), allow Number values#101
Merged
Conversation
|
gibson042
approved these changes
Apr 23, 2026
Co-authored-by: Richard Gibson <richard.gibson@gmail.com>
jessealama
approved these changes
Apr 29, 2026
jessealama
added a commit
that referenced
this pull request
Apr 29, 2026
…r values Aligns Amount.prototype.convertTo with the README updates from #101: replaces the min/max fraction/significant digit options and roundingPriority with the constructor-style fractionDigits and significantDigits (mutually exclusive, throwing RangeError if both are set). When neither precision option is supplied — or the converted value is non-finite — the resulting Amount is now Number-backed rather than always String-backed.
jessealama
added a commit
that referenced
this pull request
May 5, 2026
…r values (#103) Aligns Amount.prototype.convertTo with the README updates from #101: replaces the min/max fraction/significant digit options and roundingPriority with the constructor-style fractionDigits and significantDigits (mutually exclusive, throwing RangeError if both are set). When neither precision option is supplied — or the converted value is non-finite — the resulting Amount is now Number-backed rather than always String-backed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following today's discussion on #90 (comment), this PR:
.convertTo()precision options (minimum/maximum fraction/significant digits) with those of the constructor, i.e.fractionDigitsandsignificantDigits, and updates their handling to correspond to what we're already doing in the constructor.roundingPriorityis dropped, as specifying bothfractionDigitsandsignificantDigitsis an error..convertTo()without any precision options, you end up with a Number-backed Amount.CC @sffc, @gibson042