First go at spec text for Amount#28
Merged
Merged
Conversation
Co-authored-by: Jordan Harband <ljharb@gmail.com>
ljharb
reviewed
Jun 3, 2025
We embrace the idea that numbers -- as strings -- are understood as unlimited. Later, we may put down some limitations, probably coming from ECMA 402.
ljharb
reviewed
Jun 4, 2025
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
This should work out-of-the-box, provided [proposal-keep-trailing-zeroes is accepted. References: + https://github.com/eemeli/ecma402/pull/1/files
This was referenced Jul 16, 2025
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
Collaborator
Author
Thanks! I believe I took care of them. |
eemeli
approved these changes
Jul 16, 2025
eemeli
left a comment
eemeli
left a comment
Member
There was a problem hiding this comment.
🚀 This is good, pending the inline fix to with() below.
eemeli
reviewed
Jul 16, 2025
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.