Reduce scope of Amount by avoiding unit conversion#29
Merged
Conversation
In discussions among various TC39 delegates, it has become clear that the concept of a unit brings up a number of challenges that can be cleanly separated from the more fundamental problem of representing mathematical values together with a precision. This is an important part of the notion of measurement that is a subset of the original motivation and argument for Measure. We propose to separate these challenges from those that come from supporting measurements, such as: * the need for unit conversion, * compound units (e.g., "foot-and-inch"), * whether: some units (and which ones?) should be included (SI?) out-of-the-box, * user-customizable units, * arithmetic: involved in conversions (rationals? decimals? binary floats?), etc.
eemeli
requested changes
Jul 2, 2025
eemeli
left a comment
eemeli
left a comment
Member
There was a problem hiding this comment.
Units and currencies must not be left out of Amount. Unit conversion and compound units can and should be left for later, but at least for me the primary purpose of Amount is for it to hold a numerical value together with an indicator of what it's an amount of.
It was an accident to drop them. They're supposed to be there. But we do not intend to support unit conversion, certainly, given the issues involved there.
Collaborator
Author
Indeed, this was a big mistake. Can you take another look? Units are, of course, supposed to be included. |
jessealama
changed the title
eemeli
requested changes
Jul 3, 2025
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
eemeli
approved these changes
Jul 10, 2025
eemeli
left a comment
eemeli
left a comment
Member
There was a problem hiding this comment.
One small nitpick/addition, otherwise looks good!
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In discussions among various TC39 delegates, it has become clear that the concept of a unit conversion brings up a number of challenges that can be cleanly separated from the more fundamental problem of representing a mathematical value, tagged with a unit, together with a precision. This is an important part of the notion of measurement that is a subset of the original motivation and argument for Measure. We propose to separate these challenges from those that come from supporting measurements, such as:
etc.