Fixes trimming for windows. \r\n are not trimmed when using TrimSuffix#14
Open
bmeyers22 wants to merge 5 commits intotcnksm:masterfrom
Open
Fixes trimming for windows. \r\n are not trimmed when using TrimSuffix#14bmeyers22 wants to merge 5 commits intotcnksm:masterfrom
bmeyers22 wants to merge 5 commits intotcnksm:masterfrom
Conversation
bmeyers22
commented
Sep 21, 2017
| resultStr = strings.Trim(line, LineSep) | ||
| // brute force for the moment | ||
| resultStr = strings.TrimSuffix(line, "\n") | ||
| resultStr = strings.TrimSuffix(resultStr, "\n") |
Author
There was a problem hiding this comment.
Note: I'm not sure of the reasoning for this line so I left it in, but I'm guessing you needed it to get rid of new lines no matter what since they probably weren't working for windows. Using Trim instead of TrimSuffix should solve this problem, so you may be able to remove this line
|
Could this be merged cc @tcnksm ? |
Closed
|
Will this ever be merged? |
|
...9102 years |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In regards to #12 this is the fix. The issues were: