Avoid adding newlines to output by default#15
Open
itskingori wants to merge 1 commit intotcnksm:masterfrom
Open
Avoid adding newlines to output by default#15itskingori wants to merge 1 commit intotcnksm:masterfrom
itskingori wants to merge 1 commit intotcnksm:masterfrom
Conversation
When newlines are hardcoded in the library, all user's of this library are forced into that ui-design choice without a way to modify that behaviour. This way, user's can opt to add newlines as they wish ... in their own tools.
3985332 to
54ca812
Compare
|
@tcnksm any chance you could provide some feedback on this? The newlines are definitely odd and would be welcome if they were removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When newlines are hardcoded in the library, all user's of this library are forced into that ui-design choice without a way to modify that behaviour. This way, user's can opt to add newlines as they wish ... in their own tools.
For example, in the example below ... I would like not two have two empty lines after "Failed to validate". And even if I did, I'd prefer to have to add them myself for flexibility.
Before:
After:
I took the liberty to remove other newlines.