TELCORE-44: add --with-crashpad-root / --with-crashpad-out configure … - #584
Open
damirn wants to merge 1 commit into
Conversation
…knobs Substitute CRASHPAD_ROOT and CRASHPAD_OUT into Makefile.am via AC_SUBST so mod_crashpad's static-lib prereqs in _LIBADD resolve at configure time rather than via Makefile.am ?= defaults. The latter were emitted by automake after the rule that referenced them, so $(CRASHPAD_OUT) expanded to empty when make parsed mod_crashpad.la's prerequisite list and the build failed with "No rule to make target '/obj/client/libclient.a'".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…knobs
Substitute CRASHPAD_ROOT and CRASHPAD_OUT into Makefile.am via AC_SUBST so mod_crashpad's static-lib prereqs in _LIBADD resolve at configure time rather than via Makefile.am ?= defaults. The latter were emitted by automake after the rule that referenced them, so $(CRASHPAD_OUT) expanded to empty when make parsed mod_crashpad.la's prerequisite list and the build failed with "No rule to make target '/obj/client/libclient.a'".