TELCORE-120: fix mod_xml_rpc build with debian trixie / gcc 14 - #590
Open
damirn wants to merge 1 commit into
Conversation
damirn
force-pushed
the
damir/telcore-120-update-freeswitch-fork-to-build-on-debian-trixie
branch
from
May 19, 2026 18:40
a4a4d9a to
a5aaba7
Compare
damirn
changed the base branch from
telnyx/telephony/deploy-development
to
damir/telcore-81-upstream-sync-with-freeswitch-v1110-release
May 19, 2026 18:40
…gcc 14 Bundled libs/xmlrpc-c declares ServerCreate(... struct in_addr * const addrP, ...) but the 2019 telnyx fork patch (cf68bd0) backing IP-bind support declared the local as in_addr_t (a uint32_t) and passed &addr. gcc <= 13 reported this as -Wincompatible-pointer-types (warning); gcc 14 (Debian Trixie default) promotes it to a hard error. Wire behavior is unchanged - struct in_addr is just { uint32_t s_addr; } - we just store the address through s_addr now.
damirn
force-pushed
the
damir/telcore-120-update-freeswitch-fork-to-build-on-debian-trixie
branch
from
June 30, 2026 11:45
a5aaba7 to
8e2febf
Compare
damirn
changed the title
damirn
changed the base branch from
damir/telcore-81-upstream-sync-with-freeswitch-v1110-release
to
damir/telcore-176-sync-freeswitch-fork-with-upstream-v1111
August 7, 2026 12:21
Author
|
updated target branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/mod/xml_int/mod_xml_rpc/mod_xml_rpc.c: declare the local bind address asstruct in_addr addr(wasin_addr_t); assign throughaddr.s_addr = inet_addr(...)(wasaddr = inet_addr(...)).Why
The bundled
libs/xmlrpc-c/include/xmlrpc-c/abyss.hdeclaresbut the 2019 telnyx fork patch cf68bd0164a backing IP-bind support declared the local var as
in_addr_t(auint32_t) and passed&addr. gcc ≤ 13 reported this as a-Wincompatible-pointer-typeswarning; gcc 14 (Debian Trixie default) promotes it to a hard error.Wire behavior is unchanged —
struct in_addris just{ uint32_t s_addr; }and the network-order layout is identical. The patch only routes the assignment throughs_addrso the type checker is happy.Test plan
freeswitch-docker-base:1.16.0(Trixie) — mod_xml_rpc compilesxml_rpc.confhttp-addresssetting still binds the configured interface (smoke: start FS withhttp-addressset,ss -lntpshows the bind)