Skip to content

TELCORE-355: propagate concrete recorder open-error detail on record_session_error #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
minhtuan1407-telnyx wants to merge 2 commits into
base: telnyx/telephony/deploy-development
Choose a base branch
from
Draft

TELCORE-355: propagate concrete recorder open-error detail on record_session_error #638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4cc793
TELCORE-355: propagate concrete recorder open-error detail on record_…
Aug 11, 2026
19a2e10
Remove ticket ID from recorder open-error code comments
Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/mod/applications/mod_av/avformat.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2328,7 +2328,20 @@ static switch_status_t av_file_open(switch_file_handle_t *handle, const char *pa

if (ret < 0) {
char ebuf[255] = "";
switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, "Could not open '%s': %s\n", file, get_error_text(ret, ebuf, sizeof(ebuf)));
get_error_text(ret, ebuf, sizeof(ebuf));
switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, "Could not open '%s': %s\n", file, ebuf);
/* Stash the concrete open error on handle->event so the
* recording layer (switch_ivr_async.c send_record_error_event) can
* distinguish an rw_timeout (recorder-server timeout) from other open
* failures. handle->event is otherwise unused on this path; the
* recording layer consumes and destroys it. */
if (!handle->event) {
switch_event_create(&handle->event, SWITCH_EVENT_CLONE);
}
if (handle->event) {
switch_event_add_header_string(handle->event, SWITCH_STACK_BOTTOM, "Record-Open-Error-Detail", ebuf);
switch_event_add_header_string(handle->event, SWITCH_STACK_BOTTOM, "Record-Open-Timeout", (ret == AVERROR(ETIMEDOUT)) ? "true" : "false");
}
switch_goto_status(SWITCH_STATUS_GENERR, end);
}
} else {
Expand Down
31 changes: 27 additions & 4 deletions src/switch_ivr_async.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1393,13 +1393,27 @@ static void send_record_stop_event(switch_channel_t *channel, switch_codec_imple
rh->start_event_sent = 0;
}

static void send_record_error_event(switch_channel_t *channel, const char* file, const char* error)
static void send_record_error_event(switch_channel_t *channel, const char* file, const char* error, switch_file_handle_t *fh)
{
switch_event_t *event;
if (switch_event_create_subclass(&event, SWITCH_EVENT_CUSTOM, "record_session_error") == SWITCH_STATUS_SUCCESS) {
switch_channel_event_set_data(channel, event);
switch_event_add_header_string(event, SWITCH_STACK_BOTTOM, "Record-File-Path", file);
switch_event_add_header_string(event, SWITCH_STACK_BOTTOM, "Record-Error", error);
/* Forward the concrete open-error detail stashed by the file
* format module (e.g. mod_av) so consumers can distinguish an rw_timeout
* (recorder-server timeout) from other open failures. Absent for file
* modules that don't populate it. */
if (fh && fh->event) {
const char *detail = switch_event_get_header(fh->event, "Record-Open-Error-Detail");
const char *timeout = switch_event_get_header(fh->event, "Record-Open-Timeout");
if (detail) {
switch_event_add_header_string(event, SWITCH_STACK_BOTTOM, "Record-Error-Detail", detail);
}
if (timeout) {
switch_event_add_header_string(event, SWITCH_STACK_BOTTOM, "Record-Open-Timeout", timeout);
}
}
switch_event_fire(&event);
}
}
Expand Down Expand Up @@ -3737,7 +3751,10 @@ SWITCH_DECLARE(switch_status_t) switch_ivr_record_session_event(switch_core_sess
switch_channel_hangup(channel, SWITCH_CAUSE_DESTINATION_OUT_OF_ORDER);
switch_core_session_reset(session, SWITCH_TRUE, SWITCH_TRUE);
}
send_record_error_event(channel, file_open_path, "Error opening file");
send_record_error_event(channel, file_open_path, "Error opening file", fh);
if (fh->event) {
switch_event_destroy(&fh->event);
}
set_completion_cause(rh, "uri-failure");
switch_goto_status(SWITCH_STATUS_GENERR, err);
}
Expand Down Expand Up @@ -3791,7 +3808,10 @@ SWITCH_DECLARE(switch_status_t) switch_ivr_record_session_event(switch_core_sess
switch_channel_hangup(channel, SWITCH_CAUSE_DESTINATION_OUT_OF_ORDER);
switch_core_session_reset(session, SWITCH_TRUE, SWITCH_TRUE);
}
send_record_error_event(channel, in_file, "Error opening file");
send_record_error_event(channel, in_file, "Error opening file", &rh->in_fh);
if (rh->in_fh.event) {
switch_event_destroy(&rh->in_fh.event);
}
set_completion_cause(rh, "uri-failure");
switch_goto_status(SWITCH_STATUS_GENERR, err);
}
Expand All @@ -3803,7 +3823,10 @@ SWITCH_DECLARE(switch_status_t) switch_ivr_record_session_event(switch_core_sess
switch_channel_hangup(channel, SWITCH_CAUSE_DESTINATION_OUT_OF_ORDER);
switch_core_session_reset(session, SWITCH_TRUE, SWITCH_TRUE);
}
send_record_error_event(channel, out_file, "Error opening file");
send_record_error_event(channel, out_file, "Error opening file", &rh->out_fh);
if (rh->out_fh.event) {
switch_event_destroy(&rh->out_fh.event);
}
set_completion_cause(rh, "uri-failure");
switch_goto_status(SWITCH_STATUS_GENERR, err);
}
Expand Down
Loading