Draft
Conversation
✅ Deploy Preview for works-council-list-helper ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Contributor
Author
Example 3it appears to be working in a lot of cases except for this one.. there are likely more failing cases. i am planning on writing a unit test suite to cover almost all of this! |
Contributor
Author
Example 4This case I'm not even sure about - the list on the right did not receive a popular distribution, but received a gender quota seat distribution. Should not the woman at the bottom of the first list receive the seat, then?
|
acao
force-pushed
the
more-localisation
branch
2 times, most recently
from
5f26d42 to
a1544ae
Compare
Member
I would have expected Solidarity to get one seat anyways through raw/popular distribution. But yes, let's say there was a gender quota of two women, I'd expect BR1, BR2, BR3 and BR6 to be elected, along with SO1 |
shushugah
reviewed
Apr 21, 2023
Contributor
Author
|
thank you for the review @shushugah !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
excited to get this working finally! gender distribution! there are some issues still
attempts to solve #6 as well by improving the UX and layout
Example 1
Example 2
does this case make sense @shushugah ?
