Skip to content

Remove tektoncd/cli prow jobs#2510

Merged
tekton-robot merged 1 commit intotektoncd:mainfrom
vdemeester:prow-remove-cli
Jul 28, 2025
Merged

Remove tektoncd/cli prow jobs#2510
tekton-robot merged 1 commit intotektoncd:mainfrom
vdemeester:prow-remove-cli

Conversation

@vdemeester
Copy link
Copy Markdown
Member

Changes

With tektoncd/cli#2516 those are no more needed.

Signed-off-by: Vincent Demeester vdemeest@redhat.com

/kind misc

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

With tektoncd/cli#2516 those are no more needed.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Mar 17, 2025
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 17, 2025
@afrittoli
Copy link
Copy Markdown
Member

afrittoli commented Mar 27, 2025

/hold until the CLI PR is merged and backported (?)

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2025
@vdemeester
Copy link
Copy Markdown
Member Author

@afrittoli thanks for the hold. tektoncd/cli doesn't do the same branch thingy as we do in pipeline today… I need to change that 😓

@divyansh42
Copy link
Copy Markdown
Member

divyansh42 commented Jul 28, 2025

We can probably remove the hold as tektoncd/cli#2516 is merged and we now have GitHub workflows in the CLI.
PR for modifying the branch protection rule #2715
/cc @afrittoli @vdemeester

@tekton-robot tekton-robot requested a review from afrittoli July 28, 2025 13:54
@tekton-robot
Copy link
Copy Markdown
Contributor

@divyansh42: GitHub didn't allow me to request PR reviews from the following users: vdemeester.

Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

We can probably remove the hold ashttps://github.com/tektoncd/cli/pull/2516 is merged and we now have GitHub workflows in the CLI.
PR for modifying the branch protection rule #2715
/cc @afrittoli @vdemeester

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@afrittoli
Copy link
Copy Markdown
Member

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2025
@afrittoli
Copy link
Copy Markdown
Member

/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2025
@tekton-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2025
@tekton-robot tekton-robot merged commit 70fd169 into tektoncd:main Jul 28, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants