Feature: Serialization context tests - #868
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 69da1abdf9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| serialization_context_continue_as_new.Feature, | ||
| serialization_context_external_signal.Feature, | ||
| serialization_context_failure.Feature, | ||
| serialization_context_local_activity_payloads.Feature, |
There was a problem hiding this comment.
When the full Go feature suite runs, this registration executes local_activity_payloads, but its README explicitly documents that the current Go SDK encodes the local-activity result without context and then decodes it with workflow context. The signing codec therefore returns a context-mismatch error before CheckResult; because the config has no skip or expected-failure mechanism, every supported current Go run reports a failure. Skip this implementation until the SDK gap is fixed.
Useful? React with 👍 / 👎.
| serialization_context.child_workflow_payloads.feature.Impl.class, | ||
| serialization_context.continue_as_new.feature.Impl.class, |
There was a problem hiding this comment.
When the Java runner is given the full feature list discovered by GlobFeatures, it includes serialization_context/child_workflow_payloads_default_id because that directory now contains feature.java. Main resolves every requested directory through PreparedFeature.ALL, but this list jumps directly from the explicit-ID child feature to continue_as_new, so it throws NoSuchElementException and aborts the Java harness before running the remaining features.
Useful? React with 👍 / 👎.
1 participant
What was changed
Why?
Implementing Serialization Context for PHP, need parity tests
Checklist
Closes
How was this tested: