Exposing CCL activation lowering flag in compiler config#5396
Open
dgolubovicTT wants to merge 1 commit into
Open
Exposing CCL activation lowering flag in compiler config#5396dgolubovicTT wants to merge 1 commit into
dgolubovicTT wants to merge 1 commit into
Conversation
dgolubovicTT
requested review from
AleksKnezevic,
acicovicTT,
acolicTT,
bmalesevicTT,
hshahTT,
jameszianxuTT,
kmabeeTT,
mrakitaTT,
mvasiljevicTT,
ndrakulicTT,
nvukobratTT,
odjuricicTT,
pilkicTT,
rpavlovicTT,
sdjukicTT,
sgligorijevicTT,
sshonTT and
vkovacevicTT
as code owners
dgolubovicTT
force-pushed
the
dgolubovic/activation-dtype-lowering
branch
from
fbbdb9b to
42d11ff
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5396 +/- ##
==========================================
- Coverage 33.80% 33.78% -0.03%
==========================================
Files 37 37
Lines 4990 4996 +6
==========================================
+ Hits 1687 1688 +1
- Misses 3303 3308 +5 ☔ View full report in Codecov by Harness. |
odjuricicTT
approved these changes
Jun 30, 2026
dgolubovicTT
force-pushed
the
dgolubovic/activation-dtype-lowering
branch
from
42d11ff to
ffe0a4e
Compare
nvukobratTT
approved these changes
Jul 1, 2026
| // / all_gather -> consumer). Pattern-matches Llama-style sub-graphs | ||
| // (O-proj+residual, MLP). Default off; flip on | ||
| // per-model after validating model accuracy doesn't degrade. | ||
| bool enable_activation_dtype_lowering = false; |
Contributor
There was a problem hiding this comment.
A general, non-blocking comment: we should think about how to unify AMP-related features/flags/switches. TBD for next iteration.
acicovicTT
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Closes #5178
What's changed
Exposing new Mixed Precision feature - CCL activation lowering, through compiler config
Future
This feature will be worked on. Mainly adding new patterns in tt-mlir to lower CCL activation dtypes in new architectures. So if this flag is on and activations around CCLs are not lowered -> please open issue to @dgolubovicTT with a repro.