Skip to content

bump(main/salty-chat): 0.0.22-p20251006#26796

Merged
robertkirkman merged 1 commit intotermux:masterfrom
robertkirkman:salty-chat-git-source
Oct 8, 2025
Merged

bump(main/salty-chat): 0.0.22-p20251006#26796
robertkirkman merged 1 commit intotermux:masterfrom
robertkirkman:salty-chat-git-source

Conversation

@robertkirkman
Copy link
Copy Markdown
Member

@robertkirkman robertkirkman commented Oct 6, 2025

  • For some reason, the release archive URL does not work anymore, but downloading the release tag using the git protocol does work.

  • However, for some reason the current release fails to build in termux-packages GitHub Actions with error ../../_cache/go1.25.0-r1/src/os/user/lookup.go:22:41: undefined: current, but not locally, but the current master branch is not affected by that error, so bump to the newest commit.

Copy link
Copy Markdown
Member

@TomJo2000 TomJo2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to get this merged ahead of #26684 so I can rebase that branch on top of this change.

@robertkirkman
Copy link
Copy Markdown
Member Author

A strange error occurred that did not happen in my local test. I will try to find out what happened.

@robertkirkman robertkirkman force-pushed the salty-chat-git-source branch 3 times, most recently from e4aa007 to 85d0e92 Compare October 7, 2025 01:53
- For some reason, the release archive URL does not work anymore, but downloading the release tag using the git protocol does work.

- However, for some reason the current release fails to build in termux-packages GitHub Actions with error ` ../../_cache/go1.25.0-r1/src/os/user/lookup.go:22:41: undefined: current`, but not locally, but the current master branch is not affected by that error, so bump to the newest commit.
@robertkirkman robertkirkman force-pushed the salty-chat-git-source branch from 85d0e92 to 745c06a Compare October 7, 2025 02:20
@robertkirkman robertkirkman changed the title fix(main/salty-chat): switch to git source protocol bump(main/salty-chat): 0.0.22-p20251006 Oct 7, 2025
@robertkirkman
Copy link
Copy Markdown
Member Author

I don't understand exactly what happened, but it was consistently reproducible only in termux-packages GitHub Actions and I discovered that it goes away if the newest version in the master branch of saltyim is used, and it would probably take a really long time to bisect which exact commit fixes that in GitHub Actions, so I am just bumping it to the newest commit to resolve that.

@TomJo2000
Copy link
Copy Markdown
Member

I'm guessing it's some hiccup between our CI and their Gitea backend.

@robertkirkman
Copy link
Copy Markdown
Member Author

Logically, it couldn't have been since it was passing the TERMUX_PKG_SHA256 check, meaning that it was building the same source code but only having an error in GitHub Actions.

@TomJo2000
Copy link
Copy Markdown
Member

I'm rebasing the Golang PR against 1.25.2 right now.
Do you think this can be merged so I can drop the salty-chat retirement commit from that branch?

@robertkirkman
Copy link
Copy Markdown
Member Author

sure, merging now

@robertkirkman robertkirkman merged commit 87b48a7 into termux:master Oct 8, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants