Skip to content

ci: do go and zig validation inside docker #28856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thunder-coding merged 3 commits into from
Mar 13, 2026
Merged

ci: do go and zig validation inside docker #28856

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b998c8
ci: Run Go and Zig validation inside docker
thunder-coding Mar 9, 2026
d8b7c8d
ci({golang,zig}_validation): remove unnecessary if for some steps
thunder-coding Mar 9, 2026
091c4bf
ci: use true for dummy command instead of echo ""
thunder-coding Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions .github/workflows/golang_validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,18 +44,17 @@ jobs:
with:
fetch-depth: 1
- name: Enable zram
if: ${{ steps.build-info.outputs.skip-building != 'true' }}
uses: ./.github/actions/zram
with:
algorithm: zstd
size: 16G
priority: 100
device_name: /dev/zram0
- name: Prepare environment
- name: Load Docker image
run: |
./scripts/run-docker.sh true
- name: Free additional disk space
run: |
./scripts/setup-ubuntu.sh
./scripts/setup-android-sdk.sh
sudo apt install ninja-build
./scripts/free-space.sh
- name: Golang validation
run: ./scripts/bin/validation ${{ matrix.target_arch }} golang ${{ matrix.batch }} || exit 1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/package_updates.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ jobs:
device_name: /dev/zram0
- name: Load Docker image
run: |
./scripts/run-docker.sh echo ""
./scripts/run-docker.sh true
- name: Free additional disk space
run: ./scripts/free-space.sh
- name: Install needed dependencies for package updates
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ jobs:
- name: Load Docker image
if: ${{ steps.build-info.outputs.free-space == 'true' && steps.build-info.outputs.skip-building != 'true' }}
run: |
./scripts/run-docker.sh echo ""
./scripts/run-docker.sh true
- name: Free additional disk space (if needed)
if: ${{ steps.build-info.outputs.free-space == 'true' && steps.build-info.outputs.skip-building != 'true' }}
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/zig_validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,17 +44,17 @@ jobs:
with:
fetch-depth: 1
- name: Enable zram
if: ${{ steps.build-info.outputs.skip-building != 'true' }}
uses: ./.github/actions/zram
with:
algorithm: zstd
size: 16G
priority: 100
device_name: /dev/zram0
- name: Prepare environment
- name: Load Docker image
run: |
./scripts/run-docker.sh true
- name: Free additional disk space
run: |
./scripts/setup-ubuntu.sh
./scripts/setup-android-sdk.sh
./scripts/free-space.sh
- name: Zig validation
run: ./scripts/bin/validation ${{ matrix.target_arch }} zig ${{ matrix.batch }} || exit 1
Expand Down
4 changes: 2 additions & 2 deletions scripts/bin/validation
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ maybe_cleanup() {
return
fi

./clean.sh
./scripts/run-docker.sh ./clean.sh
rm -rf ./output/*
}

Expand All @@ -215,7 +215,7 @@ for package in "${PACKAGES[@]}"; do
# Header
echo "INFO: Building ${package} for ${ARCH}"
maybe_cleanup "${package}"
./build-package.sh -I -f -a "${ARCH}" "${package}"
./scripts/run-docker.sh ./build-package.sh -I -f -a "${ARCH}" "${package}"
status="${PIPESTATUS[0]}"
echo # newline
echo "INFO: Building ${package} for ${ARCH} took $(ms_to_human_readable $(( $(date +%10s%3N) - start )))"
Expand Down
Loading