feat: Add support for allowed list of domains for https redirect - #470
feat: Add support for allowed list of domains for https redirect#470sarnepalli wants to merge 2 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
c40fe62 to
47db538
Compare
0694e6a to
19686f5
Compare
dbb551e to
1a1c1a5
Compare
1a1c1a5 to
94316e7
Compare
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
|
bump |
|
Could we get someone to re-run /gcbrun on this please? |
|
/gcbrun |
dd96f7d to
97c4f21
Compare
|
@imrannayer can you please re-run gcbrun |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
|
ping |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
|
bump |
3 participants
This PR adds the "https_redirect_domains" list variable, serving as an allowlist of valid hosts for HTTP requests that will be redirected to HTTPS.
HTTP requests with a host header not included in the allowlist will not be redirected to HTTPS, and will return a 404 error instead- similar to the HTTPS behavior with invalid host headers.
If https_redirect_domains is not explicitly defined, then by default https_redirect_domains : ["*"] preserves the existing behavior of redirecting all http requests.