build(deps): bump tzdata from 1.1.3 to 1.1.4 - #5614
Conversation
On OTP 29, :calendar.time_to_seconds/1 no longer accepts the {24, 0, 0}
timestamps that legitimately occur in IANA transition times, so the
tzdata release updater crashes on every poll and installations stay
pinned to the 2025a data bundled with tzdata 1.1.3. Version 1.1.4
fixes the period builder and ships 2026b data (lau/tzdata#166).
✅ Deploy Preview for teslamate ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
JakobLichterfeld
added
the
dependencies
|
Thanks. Please download and apply the automatic patch for the nix hash mismatch: https://github.com/teslamate-org/teslamate/actions/runs/31854779580/artifacts/9245687366 |
JakobLichterfeld
left a comment
JakobLichterfeld
left a comment
There was a problem hiding this comment.
Thanks @mews-se for your first contribution — excellent work! Much appreciated that you traced this to lau/tzdata#166 and verified the fix in the builder image against the current IANA release. The bump itself checks out: the lock entry matches the hex.pm checksum for 1.1.4, and all version constraints are satisfied.
As already mentioned, the Nix fixed-output hash in nix/flake-modules/package.nix needs to be regenerated for the new dep set — nix run .#update-nix-hashes does it for you; commit the resulting change or use the provided patch.
After that this is good to merge. Thanks again for the thorough investigation!
🤖 Review drafted with Claude Code (Fable 5 high) — sponsored by Claude for Open Source
|
Applied the patch, thanks for making that painless. Took the PR out of draft too. |
JakobLichterfeld
left a comment
JakobLichterfeld
left a comment
There was a problem hiding this comment.
Thanks for quick turnaround.lgtm
3 participants
Fixes #5605.
tzdata 1.1.3 crashes on OTP 29 because
:calendar.time_to_seconds/1no longer accepts the{24, 0, 0}timestamps that legitimately occur in IANA transition times ("24:00"). The:tzdata_release_updaterprocess crashes on every poll, so installations stay pinned to the 2025a data bundled with the package. Fixed upstream in lau/tzdata#166, released in 1.1.4 (which also ships 2026b data).Verified in the builder image (
elixir:1.20.2-otp-29): building periods from the current IANA release (2026c) crashes with 1.1.3 with the same stack trace as #5605, and succeeds with 1.1.4 (all 340 zones).