Skip to content

fix: compatibility with html-validate 8.x #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cebreus wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: compatibility with html-validate 8.x #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 10 additions & 14 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,27 +19,23 @@ module.exports = gulpHtmlValidate;
function gulpHtmlValidate() {
const htmlvalidate = htmlValidateCli.getValidator();

return through.obj((file, encoding, callback) => {
if (file.isNull()) {
callback(null, file);
return;
}
return through.obj(async (file, encoding, callback) => {
try {
if (file.isNull() || file.isStream()) {
throw new PluginError(pluginName, 'File is null or Streaming not supported');
}

if (file.isStream()) {
callback(new PluginError(pluginName, 'Streaming not supported'));
const result = await htmlvalidate.validateString(file.contents.toString(), file.path);
file.htmlValidateResult = result;
} catch (err) {
callback(err);
return;
}

const result = htmlvalidate.validateString(
file.contents.toString(),
file.path
);
file.htmlValidateResult = result;

callback(null, file);
});
}


/**
* Print a report where all errors/warnings are listed.
*
Expand Down