Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/gradle-wrapper-validation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ jobs:
name: "Validation"
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: gradle/actions/wrapper-validation@v5
- uses: actions/checkout@v6
- uses: gradle/actions/wrapper-validation@v2

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "Latest gradle/actions release tag:"
curl -fsSL https://api.github.com/repos/gradle/actions/releases/latest \
  | sed -n 's/.*"tag_name": "\(v[^"]*\)".*/\1/p' | head -n1

echo
echo "Official wrapper-validation doc usage:"
curl -fsSL https://raw.githubusercontent.com/gradle/actions/main/docs/wrapper-validation.md \
  | grep -n 'uses: gradle/actions/wrapper-validation@v' | head -n3

Repository: testng-team/testng

Length of output: 244


Upgrade wrapper-validation to the current major version on Line 10.

The action is pinned to @v2, but the current major is @v6 (v6.1.0), as confirmed by the official Gradle documentation and latest releases. Keeping the older version defeats the PR's goal of using current versions and risks deprecated runtime behavior.

Suggested fix
-      - uses: gradle/actions/wrapper-validation@v2
+      - uses: gradle/actions/wrapper-validation@v6
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/gradle-wrapper-validation.yml at line 10, Update the
GitHub Actions step that references the Gradle wrapper validation action by
changing the pinned version from gradle/actions/wrapper-validation@v2 to the
current major release gradle/actions/wrapper-validation@v6 (e.g., v6.1.0) so the
workflow uses the latest supported major version; locate the step in the
workflow that contains the action identifier
"gradle/actions/wrapper-validation@v2" and replace the version tag accordingly.

2 changes: 1 addition & 1 deletion .github/workflows/label-commenter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@ jobs:
if: github.repository_owner == 'testng-team'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
- name: Label Commenter
uses: peaceiris/actions-label-commenter@v1
4 changes: 2 additions & 2 deletions .github/workflows/publish-maven-central.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
# Steps represent a sequence of tasks that will be executed as part of the job
steps:
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
- uses: actions/checkout@v4
- uses: actions/checkout@v6

- name: Gradle wrapper validation
uses: gradle/actions/wrapper-validation@v3
Expand All @@ -34,7 +34,7 @@ jobs:
# 2. Running the nmcp plugin (requires Java 17+)
# Note: TestNG artifacts still target Java 11 (targetJavaVersion=11)
- name: Set up JDK 21
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
distribution: 'zulu'
java-version: 21
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish-snapshot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
publish-snapshot:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6

- name: Gradle wrapper validation
uses: gradle/actions/wrapper-validation@v3
Expand All @@ -20,7 +20,7 @@ jobs:
# 2. Running the nmcp plugin (requires Java 17+)
# Note: TestNG artifacts still target Java 11 (targetJavaVersion=11)
- name: Set up JDK 21
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
distribution: 'zulu'
java-version: 21
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
# Ask matrix.mjs to produce 7 jobs
MATRIX_JOBS: 7
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
with:
fetch-depth: 1
- id: set-matrix
Expand All @@ -45,17 +45,17 @@ jobs:
env:
TZ: ${{ matrix.tz }}
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
with:
fetch-depth: 10
- name: Set up Java ${{ matrix.java_version }}, oracle
if: ${{ matrix.oracle_java_website != '' }}
uses: oracle-actions/setup-java@2e744f723b003fdd759727d0ff654c8717024845 # v1.4.0
uses: oracle-actions/setup-java@fff43251af9936a0e6a4d5d0946e14f1680e9b6b # v1.5.0
with:
website: ${{ matrix.oracle_java_website }}
release: ${{ matrix.java_version }}
- name: Set up Java 21 and ${{ matrix.non_ea_java_version }}, ${{ matrix.java_distribution }}
uses: actions/setup-java@v4
uses: actions/setup-java@v5
with:
# Install multiple Java versions:
# - Test version (11, 17, 21, 25, or 26): Used to run TestNG tests
Expand All @@ -66,7 +66,7 @@ jobs:
distribution: ${{ matrix.java_distribution }}
architecture: x64
- name: Steps to reproduce
uses: actions/github-script@v7
uses: actions/github-script@v9
with:
script: |
console.log('The following command might help reproducing CI results, use Java ${{ matrix.java_version }}')
Expand All @@ -76,7 +76,7 @@ jobs:
run: echo "unique_id=$(date +%s)" >> $GITHUB_OUTPUT
- name: Test
id: run_test_cases
uses: burrunan/gradle-cache-action@v2
uses: burrunan/gradle-cache-action@v3
with:
job-id: jdk${{ matrix.jdk.version }}
arguments: |
Expand All @@ -93,7 +93,7 @@ jobs:
org.gradle.java.installations.auto-download=false
- name: Upload build reports
if: ${{ failure() && steps.run_test_cases.outcome == 'failure' }}
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
with:
name: build-reports-${{ matrix.jdk.group }}-${{ matrix.jdk.version }}-${{ steps.build_id.outputs.unique_id }}
path: testng-core/build/reports/tests/test/**
2 changes: 1 addition & 1 deletion .github/workflows/update-gradle-wrapper.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6

- name: Update Gradle Wrapper
uses: gradle-update/update-gradle-wrapper-action@v2