Fix build failures with modern CMake and Clang#27
Open
kenchangh wants to merge 1 commit into
Open
Conversation
- Add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to libiio, libad9361-iio, and iio-oscilloscope to fix CMake 4.x rejecting cmake_minimum_required < 3.5 - Add -Wno-error=implicit-function-declaration to libad9361-iio and iio-oscilloscope to fix Clang 16+ treating missing includes as errors - Remove libglade dependency from iio-oscilloscope as it was removed from Homebrew and is not needed (the code uses GtkBuilder, not libglade) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-DCMAKE_POLICY_VERSION_MINIMUM=3.5to libiio, libad9361-iio, and iio-oscilloscope to fix CMake 4.x rejectingcmake_minimum_requiredversions below 3.5-Wno-error=implicit-function-declarationto libad9361-iio and iio-oscilloscope to fix Clang 16+ treating missing#include <stdio.h>as a hard errorlibgladedependency from iio-oscilloscope — it was removed from Homebrew in 2023 and is not actually needed (the code usesGtkBuilderto load.gladefiles, not the deprecatedlibgladelibrary)Test plan
brew install --build-from-sourcesucceeds for all three formulae on macOS 26.2 (arm64) with Xcode 26.2 and CMake 4.2.3osc --helpruns successfully after installationoscGUI launches without errors🤖 Generated with Claude Code