Add domain whitelisting - #45
Open
guilebc wants to merge 1 commit into
Open
Conversation
tgallice
reviewed
Mar 5, 2017
| { | ||
| return [ | ||
| DomainWhitelisting::WHITELISTED_DOMAINS => $this->domains, | ||
| DomainWhitelisting::DOMAIN_ACTION_TYPE => $this->action |
Owner
There was a problem hiding this comment.
Are you sure this is needed ? No mention of that in the documentation.
tgallice
reviewed
Mar 5, 2017
| * @return array | ||
| */ | ||
| private function buildSetting($type, $threadState = null, $value = null) | ||
| private function buildSetting($type, $threadState = null, $value = null, $mergeValueWithSetting = false) |
Owner
There was a problem hiding this comment.
The documentation look like to be updated. No need to threadState and setting_type anymore. Maybe a rewrite of this function should be better.
tgallice
reviewed
Mar 5, 2017
|
|
||
| use Tgallice\FBMessenger\Model\ThreadSetting\DomainWhitelisting; | ||
|
|
||
| class WhitelistedDomains |
Owner
There was a problem hiding this comment.
I'm not sure about the need of this class. Or It's should be more generic. Maybe rename DomainWhitelisting to DomainWhitelist and used it instead of WhitelistedDomains. The DomainWhitelist should contain only domain list.
Owner
|
@guilebc sorry for the delais, just some comments but it's cool 👍 thank. |
Contributor
|
@tgallice - is there a plan to merge this pull request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Domain whitelisting feature for the Messenger Extensions & Plugin Checkbox.
https://developers.facebook.com/docs/messenger-platform/thread-settings/domain-whitelisting
Tell me if ok for you.