Adding support for elogind's standalone logind daemon.#117
Open
roogus wants to merge 1 commit intothe-cavalry:masterfrom
roogus:master
Open
Adding support for elogind's standalone logind daemon.#117roogus wants to merge 1 commit intothe-cavalry:masterfrom roogus:master
roogus wants to merge 1 commit intothe-cavalry:masterfrom
roogus:master
Conversation
|
Doesn't run for me with lightdm-1.26.0-r1, system can't be unlocked. Will investigate further. |
|
Sorry, stupid me forgot how to patch, everything works for me. |
|
Confirmed here too that this patch fixes black screen when unlocking if xorg is compiled with elogind support |
|
This patch fails to build on a non-elogind system though with
|
casta
reviewed
Mar 28, 2019
| AC_DEFINE(WITH_ELOGIND, 1, [elogind support]) | ||
| fi | ||
| AC_SUBST(ELOGIND_CFLAGS) | ||
| AC_SUBST(ELOGIND_LIBS, [-lelogind]) |
There was a problem hiding this comment.
This should be: AC_SUBST(ELOGIND_LIBS)
adding [-lelogind] unconditionally add -lelogind to linkage, even if elogind support id disabled (thus failing at link step)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR completes the work started by @dg98 in PR #109 . It adds the necessary preprocessor directives to make use of the --with-elogind autoconf option previously introduced, and explicitly links with the elogind library to provide full functionality.
These changes compile and run as expected (afik) on my gentoo machine with: lightdm-1.28.0, elogind-238.1, and openrc-0.38.2 which should resolve #103 .
This is my first go-round with autotools scripting, so any comments/critiques are most welcome.