fix: exercise valid Rust release smoke - #1008
Merged
Merged
Conversation
Greptile SummaryThe PR updates Rust release smoke checks to invoke the native greeting-validator protocol for raw and archive-extracted executables.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| scripts/rust-distribution.js | Replaces invalid no-argument smoke execution with the native greeting-validator protocol for raw and extracted binaries. |
| tests/unit/rust-distribution.test.js | Adds a non-Windows shell fixture that verifies the argument and exact file/stdin greeting bytes using cmp. |
Reviews (2): Last reviewed commit: "fix: exercise valid Rust release smoke" | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
tomdps
enabled auto-merge
August 12, 2026 16:37
tomdps
force-pushed
the
codex/fix-rust-release-smoke
branch
from
August 12, 2026 16:39
0fb0c44 to
74f521a
Compare
|
🎉 This PR is included in version 6.39.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: exercise the existing native greeting-validator protocol for both raw and extracted release executables, preserving the native entrypoint contract. Root cause: Release run 31615491026 failed all five targets because the smoke invoked the intentionally no-args-invalid native stdio entrypoint. Validation: real optimized binary and archive passed; full test suite, lint, typecheck, release workflow guard, Opcore and Opcore Zero passed; independent review approved with no P0-P3 findings.