fix(delivery): support custom pull request bodies - #1012
Merged
Conversation
Greptile SummaryThis PR adds deterministic custom pull-request body templates to run and finish workflows while preserving templates across detached and resumed execution.
Confidence Score: 5/5The PR appears safe to merge, with no concrete blocking or independently actionable non-blocking defects identified. Custom bodies remain unrendered while crossing detached and persisted state boundaries, are rendered against the authoritative issue payload at delivery time, and are shell-quoted before inclusion in provider commands.
|
| Filename | Overview |
|---|---|
| src/pr-body-template.js | Introduces bounded PR-body normalization and deterministic issue-token rendering, including safe behavior when issue metadata is unavailable. |
| src/agents/git-pusher-template.js | Integrates rendered, shell-quoted custom bodies into GitHub, GitLab, and Azure DevOps delivery prompts without changing merge-mode behavior. |
| src/orchestrator.js | Persists custom body templates, forwards them into generated delivery agents, and corrects resumed issue-number lookup. |
| src/legacy-lib/start-cluster-run-options.ts | Carries the unrendered body through canonical foreground and daemon start options. |
| src/legacy-lib/detached-startup.ts | Persists custom body metadata in provisional detached cluster records for later startup and recovery. |
| cli/index.js | Exposes the new run and finish flags and safely renders custom or default bodies into finish-agent commands. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
CLI["run / finish --pr-body"] --> Options["Canonical run options"]
Options -->|foreground| Orchestrator["Orchestrator"]
Options -->|detached JSON environment| Daemon["Detached child"]
Daemon --> Orchestrator
Orchestrator --> Persist["Persist unrendered prOptions.prBody"]
Persist --> Resume["Resume / finish"]
Orchestrator --> Render["Render deterministic issue tokens"]
Resume --> Render
Render --> Quote["Shell-quote body and metadata"]
Quote --> Provider{"Git platform"}
Provider --> GitHub["gh pr create --body"]
Provider --> GitLab["glab mr create --description"]
Provider --> Azure["az repos pr create --description"]
Reviews (1): Last reviewed commit: "fix(delivery): support custom pull reque..." | Re-trigger Greptile
|
🎉 This PR is included in version 6.39.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1011.
Summary
--pr-body <template>for run and finish, with deterministic issue tokensValidation
A local full-suite attempt was stopped after the shared tmpfs filled and cascaded into ENOSPC failures; required GitHub CI is the authoritative clean full-suite run.