docs: document classification routing and custom workflow graphs - #1015
Merged
Conversation
Greptile SummaryThe PR expands the README with classification routing, custom workflow configuration, and CLI references, while refining the description of validator rejection output.
Confidence Score: 4/5The PR should not merge until the outstanding foreground PR-mode routing documentation mismatch is corrected. The README promises a validator for every TRIVIAL TASK or DEBUG Files Needing Attention: README.md
|
| Filename | Overview |
|---|---|
| README.md | Adds routing and workflow documentation, but the PR-mode routing row remains inconsistent with the foreground conductor call path. |
Reviews (2): Last reviewed commit: "docs: document classification routing an..." | Re-trigger Greptile
The README describes the executor-verifier loop as if it were universal. getBase() in src/config-router.ts routes TRIVIAL to single-worker with zero validators, and any DEBUG above TRIVIAL to debug-workflow, so a reader can't tell from the page what a given task will actually get. Adds the routing table, in router precedence order, with the TRIVIAL exception stated. --config and the zeroshot config commands appeared zero times in the README despite shipping in cli/index.js. Adds a short section on writing your own graph, plus both commands in the reference block. Also drops the "reproducible failure" promise in the Open Engine section. validator-requirements requires command evidence for PASS/FAIL, but validator-code and validator-security return free-text errors[] with no command to re-run, so the guarantee doesn't hold for every rejection. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LeBinMzJJjDvW2fPSAu14S
EivMeyer
force-pushed
the
eivind/readme-routing-config
branch
from
August 13, 2026 12:12
70d72da to
36c322e
Compare
|
🎉 This PR is included in version 6.39.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two gaps in the current README, both verified against
mainat7be7eea.The routing isn't on the page. The README presents the executor–verifier loop as universal.
getBase()insrc/config-router.ts:61-73says otherwise: TRIVIAL goes tosingle-workerwith no validator at all, and any DEBUG above TRIVIAL goes todebug-workflow, which is an investigator/fixer/tester shape rather than executor plus verifier. "Fix a login bug" is one of the README's own good-fit examples and lands on that second path. The new table lists the rules in router precedence order, first match wins, and states the TRIVIAL exception rather than leaving it to be discovered.--configwas invisible.zeroshot run --config(cli/index.js:2709) andzeroshot config list/show/validate(cli/index.js:4709+) appeared zero times in the README, so the page reads as a fixed pipeline when the runtime is a general graph engine. Adds a short section and both commands in the reference block.Every claim in the new sections checked against source:
conditiongates incluster-templates/base-templates/full-workflow.json, againstgetValidatorCount()meta-coordinatorloadingquick-validationthenheavy-validation, 2 validators eachconductor-bootstrap.jsonsrc/logic-engine.js:12,166evaluates them in avmsandboxsrc/config-validator.js:1660-1680errors on a 3+ ring with no escape logic, warns when there isMAX_DEPTH = 5insrc/config-validator.js:84One copy change
The Open Engine section promised "approve, or a reproducible failure." Only
validator-requirementsrequires command evidence (criteriaResults[].evidencewith command, exitCode, output).validator-codeandvalidator-securityreturn free-texterrors[], and an instant-reject on a swallowed error has no command to re-run. Changed to the specific objections that blocked it, which is what those validators actually return.Docs only. Prettier clean. Companion to #1014; both lift the parts of #863 that are still true after the README rewrite in #945.
🤖 Generated with Claude Code
https://claude.ai/code/session_01LeBinMzJJjDvW2fPSAu14S