test: wait for resume daemon before cleanup - #878
Open
EivMeyer wants to merge 1 commit into
Open
Conversation
Greptile SummaryThe PR makes the concurrent
Confidence Score: 5/5The PR appears safe to merge, with the new wait correctly fencing teardown against the detached daemon’s remaining lifetime. The successful racer reliably reports its detached daemon PID, and waiting for that process to exit before the test returns prevents the subsequent teardown from deleting the isolated home while the daemon may still be shutting down.
|
| Filename | Overview |
|---|---|
| tests/e2e/resume-detach-daemon.test.js | Adds a correctly ordered daemon-process termination wait before the test returns and triggers isolated-home teardown. |
Reviews (1): Last reviewed commit: "test: wait for resume daemon before clea..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resume --detachdaemon PID to exit after durable cluster completion.zeroshotRoot cause
PR #863 exposed an
ENOTEMPTYfailure in the test'safterEachcleanup. The test waited forclusters.jsonto reachstopped, but that is a durable cluster-state boundary, not proof that the detached daemon process has finished its shutdown writes. Teardown could therefore race the daemon inside.zeroshot.This change waits on the daemon PID already reported by the winning resume command, so teardown starts only after the process boundary is terminal.
Verification
mocha tests/e2e/resume-detach-daemon.test.js: 4 passing