refactor: migrate runtime configuration to TypeScript - #992
Merged
Conversation
tomdps
marked this pull request as ready for review
August 12, 2026 00:14
Greptile SummaryThe PR migrates several runtime configuration and formatting modules to strict TypeScript while preserving their emitted CommonJS paths.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| cli/message-formatter-utils.ts | Adds shared lifecycle-event formatting and validation-criteria partitioning helpers without changing established output behavior. |
| cli/message-formatters-normal.ts | Replaces the normal-mode CommonJS source with strict TypeScript while retaining its formatter exports and rendering behavior. |
| src/task-run-model-args.ts | Migrates nested model argument and isolated-settings resolution to unknown-first TypeScript validation while preserving emitted runtime behavior. |
| src/worktree-claude-config.ts | Migrates Claude settings-overlay handling to TypeScript while retaining canonical-path, ownership, mode, and symlink guards. |
| src/name-generator-shared.ts | Centralizes word lists and random-name primitives for runtime and task-lib consumers. |
| task-lib/name-generator.ts | Delegates task and schedule name generation to the shared implementation while preserving task-lib fallbacks and ESM exports. |
| src/name-generator.ts | Preserves the existing runtime name-generator CommonJS interface through a TypeScript wrapper. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
TS[Strict TypeScript sources] --> LR[build:legacy-runtime]
TS --> TL[build:task-lib]
LR --> CJS[Runtime CommonJS files]
TL --> ESM[Task-lib ESM files]
CJS --> CLI[CLI and orchestration consumers]
CJS --> Claude[Claude overlay and nested-task consumers]
ESM --> Tasks[Task store and scheduler consumers]
TS --> Shared[Shared formatter and name-generator helpers]
Shared --> CJS
Shared --> ESM
Reviews (2): Last reviewed commit: "chore: ignore generated runtime JavaScri..." | Re-trigger Greptile
|
🎉 This PR is included in version 6.39.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Each migration is a separate commit. Emitted CommonJS paths remain unchanged for runtime and package consumers.
Validation
npm run opcore:checknpm run typechecknpm test— 2,897 passing, 18 pendingnpm run prepacknpx mocha tests/package-smoke.test.js --timeout 120000